Skip to content

Fix missing exports from json.cppm#5137

Merged
nlohmann merged 7 commits intonlohmann:developfrom
mikomikotaishi:patch-1
May 8, 2026
Merged

Fix missing exports from json.cppm#5137
nlohmann merged 7 commits intonlohmann:developfrom
mikomikotaishi:patch-1

Conversation

@mikomikotaishi
Copy link
Copy Markdown
Contributor

@mikomikotaishi mikomikotaishi commented Apr 15, 2026

[Describe your pull request here. Please read the text below the line and make sure you follow the checklist.]

This pull request restores some missing symbols that were present in the <nlohmann/json.hpp> header, but weren't exported in json.cppm. These include specialisations in namespace std (such as hash<> and less<>), as well as nlohmann::literals::json_literals::*. This is necessary as without this those specialisations and symbols are inaccessible from the module.

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

@github-actions github-actions Bot added the M label Apr 15, 2026
Comment thread docs/mkdocs/docs/features/modules.md Outdated
@mikomikotaishi
Copy link
Copy Markdown
Contributor Author

@nlohmann Hi, checking in on this again, is it ready to merge?

Copy link
Copy Markdown
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.12.1 milestone May 8, 2026
@nlohmann nlohmann merged commit a64fc21 into nlohmann:develop May 8, 2026
142 checks passed
@nlohmann
Copy link
Copy Markdown
Owner

nlohmann commented May 8, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants